Repository navigation
【Infer Symbolic Shape No.131】Add infer_symbol_shape for cholesky_solve_op - #69005
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Sorry to inform you that 42f1f36's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
… CINN-shapeinfer-5
| const auto &x_rank = x_shape.size(); | ||
| const auto &y_rank = y_shape.size(); | ||
|
|
||
| infer_context->AddEqualCstr(x_shape[x_rank - 2], x_shape[x_rank - 1]); |
Contributor
Author
There was a problem hiding this comment.
如上述，应该是没有的，这里的 x 就是 API 的 Y
Comment on lines
+2218
to
+2223
| const auto &x_shape_or_data = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(1)); | ||
| const std::vector<symbol::DimExpr> &x_shape = x_shape_or_data.shape(); | ||
| const auto &y_shape_or_data = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(0)); | ||
| const std::vector<symbol::DimExpr> &y_shape = y_shape_or_data.shape(); |
Contributor
There was a problem hiding this comment.
operand_source(0) 应该是x吧，这里为什么是y
Contributor
Author
There was a problem hiding this comment.
这个地方是因为Cholesky 第一个输入是B,第二个输入是 A 的Cholesky 分解的上三角矩阵，为了对齐其他的solve的实现，这里就反转了一下，可能语义上有问题。
|
Sorry to inform you that f622054's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Hongqing-work
approved these changes
Nov 20, 2024
zyfncg
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
New features
Description
其中cholesky_solve_op 原本没有单测，但是搜索PR发现 #64457 曾经被划入deprecated，并在该PR中移除，目前可以通过symbol infer 检查